igraph / rigraph

igraph R package

https://r.igraph.org

543 stars 201 forks source link

feat: Support `fit_power_law(implementation = "plfit.p")` to compute the P-value #1386

Closed krlmlr closed 1 month ago

krlmlr commented 4 months ago

Closes #1158.

aviator-app[bot] commented 4 months ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

aviator-app[bot] commented 4 months ago

This pull request failed to merge: this PR is in draft state. Once the issues are resolved, remove the blocked label and re-queue the pull request. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Additional debug info: PR was marked as draft after queueing

maelle commented 3 months ago

I see I was tasked with refining the interface as needed, but I'd need some more pointers/context.

Antonov548 commented 2 months ago

@krlmlr I have added R_igraph_power_law_fit_new() and seems R_igraph_power_law_fit() not used anymore.

I have created R_igraph_power_law_fit_new() which doesn't use R_igraph_power_law_fit() to create result list with correct amount of fields.

I assume there is no tests for this function right now? I think we might need to add it using snapshot?

krlmlr commented 1 month ago

Thanks!

aviator-app[bot] commented 1 month ago

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Once the issues are resolved, remove the blocked label and re-queue the pull request. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).

maelle commented 1 month ago

@Antonov548 I resolved the conflict in src/cpp11.cpp by rebasing locally and running cpp11::cpp_register() in R but I wouldn't mind your checking I didn't do anything wrong. :pray: If it's all good, please re-add the mergequeue label. Thank you!

Antonov548 commented 1 month ago

@Antonov548 I resolved the conflict in src/cpp11.cpp by rebasing locally and running cpp11::cpp_register() in R but I wouldn't mind your checking I didn't do anything wrong. 🙏 If it's all good, please re-add the mergequeue label. Thank you!

Thanks. Seems everything is fine.

maelle commented 1 month ago

thank you @Antonov548!