igraph / rigraph

igraph R package
https://r.igraph.org
532 stars 200 forks source link

fix: Fix compatibility layer for `eccentricity()` and `radius()` #1394

Open krlmlr opened 3 weeks ago

aviator-app[bot] commented 3 weeks ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR is not ready to merge (currently in state blocked): some CI status(es) failed.

Once the issues are resolved, remove the blocked label and re-queue the pull request. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Pending Status Checks


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.
aviator-app[bot] commented 3 weeks ago

This pull request failed to merge: some CI status(es) failed. Once the issues are resolved, remove the blocked label and re-queue the pull request. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Failed CI(s): Check ubuntu-20.04 (release)

maelle commented 1 day ago

@krlmlr can you please remind me the context of this change? I find the error message below a bit confusing, as the missing argument name is weights?

library("igraph")
#> 
#> Attaching package: 'igraph'
#> The following objects are masked from 'package:stats':
#> 
#>     decompose, spectrum
#> The following object is masked from 'package:base':
#> 
#>     union
withr::local_seed(42)
g <- make_tree(10, 2)
radius(g, NULL, "out")
#> Warning: The `...` argument of `radius()` is deprecated as of igraph 2.1.0.
#> ℹ The argument `mode` must be named.
#> This warning is displayed once every 8 hours.
#> Call `lifecycle::last_lifecycle_warnings()` to see where this warning was
#> generated.
#> Error in `radius_dijkstra_impl()` at rigraph/R/paths.R:323:3:
#> ! `arg` must be length 1, not length 0

Created on 2024-07-02 with reprex v2.1.0