search

igraph / rigraph

igraph R package
https://r.igraph.org
532 stars 200 forks source link

fix: `subgraph_centrality()` now ignores edge directions #1414

Closed szhorvat closed 1 day ago

szhorvat commented 1 week ago

The method that this function uses does not work in general for directed graphs, and the concept of subgraph centrality is normally defined for undirected graphs only.

I consider this a bugfix, so I don't think any lifecycle work is necessary. A revdepcheck will be useful, as some users may have tried to use this for directed graphs (in which case the function wouldn't return meaningful results, as already indicated in its documentation).

Please consider including this simple fix in the next release.

aviator-app[bot] commented 1 week ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.
szhorvat commented 1 week ago

@maelle Please have a look at how I access functions from the Matrix library in the test. Is this the customary way in tests?