search

igraph / rigraph

igraph R package
https://r.igraph.org
542 stars 200 forks source link

TODOs in `rinterface_extra.c` #1454

Open maelle opened 3 weeks ago

maelle commented 3 weeks ago

rinterface_extra.c has 

  /* TODO: Change igraph_i_graphlets_project to igraph_graphlets_project, because
   * we should not depend on non-public functions from igraph.

Are those still relevant? @szhorvat @Antonov548

Antonov548 commented 3 weeks ago

rinterface_extra.c has

  • 7 TODOs /* TODO: serialization */
  • 1 TODO
  /* TODO: Change igraph_i_graphlets_project to igraph_graphlets_project, because
   * we should not depend on non-public functions from igraph.

Are those still relevant? @szhorvat @Antonov548

I'm not sure what /* TODO: serialization */ mean, it's something old.

Another TODO regarding igraph_i_graphlets_project seems relevant and should be fixed.

maelle commented 2 weeks ago

@Antonov548 Thank you!