search

igraph / rigraph

igraph R package
https://r.igraph.org
542 stars 200 forks source link

TODO in `src/igraph_vector.hpp` #1459

Open maelle opened 3 weeks ago

maelle commented 3 weeks ago

@Antonov548 what to do about https://github.com/igraph/rigraph/blob/15a70e6b6fe5ec7834f81307ed97bcc634bd66a8/src/igraph_vector.hpp#L44?

szhorvat commented 3 weeks ago

This is a longer-term thing. We will use the new C++ wrapper which is being developed at https://github.com/igraph/igraph-cpp but isn't ready for use yet.

maelle commented 3 weeks ago

Should this comment be removed as we won't forget to do that then? Or am I misunderstanding?

Antonov548 commented 3 weeks ago

Should this comment be removed as we won't forget to do that then? Or am I misunderstanding?

Yes, it was just prototype for C++ wrapper. I guess this comment could be removed. P.S. or better to keep it, since it's really longer-term thing.

maelle commented 2 weeks ago

@szhorvat would you vote for keeping or removing it?

Thanks both!