igraph / rigraph

igraph R package
https://r.igraph.org
543 stars 201 forks source link

Use doubles instead of ints in R for igraph_integer_t #890

Open szhorvat opened 1 year ago

szhorvat commented 1 year ago

Values which have type INTEGER in functions.yaml should be handled as type numeric, and not type integer, in R. This is so that we can support values greater than $2^{31}-1$.

This change needs to be done in:

I have already updated most of the hand-written code where possible, but I did not add overflow checks for the double -> igraph_integer_t conversion. This should be done as well, as the last step.

szhorvat commented 8 months ago

@krlmlr It seems to me that the parts which are essential for a 2.0 release are done. I'm removing this from the upgrade milestone. Re-add it if you disagree.