Changes to .reek.yml not updated in VSCode integration

thejonroberts commented 4 days ago

The issues from #2 are fixed (very quickly, nice work!).

There is no LSP server error when .reek.yml is updated... However, config changes are not reflected in syntax highlighting.

For example, going from an 'empty' config file to:

---
detectors:
  IrresponsibleModule:
    enabled: false

Will restart the add on, but this will still be shown in the file:

Notes:

File was opened before config change.
Warning is still present if file is closed/re-opened.
Goes away if Ruby LSP server restarted.
I confirmed that changes to .rubocop.yml are reflected without restart (both in rubyLsp.linters VSCode config)

Not as big an issue as previous, config shouldn't change often, & restarting LSP is easy. But unexpected behavior nonetheless.

igray commented 3 days ago

Unfortunately, I don't use VSCode and nvim-lsp does not have the config-file detection, so I'm flying a bit blind here. I'll try to see what rubocop is doing and try to emulate that.

thejonroberts commented 3 days ago

Understandable! Again, I don't think it is urgently needed, hopefully if other people run into the issue they will find this and know to just restart the server.

I will poke around some myself. If you want me to test out a branch locally, feel free to ping me!

igray / ruby-lsp-reek

Changes to .reek.yml not updated in VSCode integration #4