search

igrigorik / closure-sprockets

Sprockets processor for Google's Closure tools
http://www.igvita.com/2011/08/16/rails-3-asset-pipeline-google-closure/
54 stars 11 forks source link

Sprockets::CircularDependencyError #8

Closed bmayen closed 12 years ago

bmayen commented 12 years ago

I'm seeing this error only on an OSX install: "Sprockets::CircularDependencyError vendor/assets/javascripts/closure-library/closure/goog/base.js has already been required"

Merely including application.js in my layout triggers it. Even if application.js doesn't provide or require anything. As far as I can tell, the OSX installation is exactly the same as my Linux installation, but it's working fine on Linux.

bmayen commented 12 years ago

Actually, after blowing away my gems and reinstalling from scratch, I'm getting the same error in my Linux installation now.

bmayen commented 12 years ago

Further clarification: Not sure what's going on here. If I roll back to the previous version by changing my Gemfile from "gem 'closure-sprockets', :git=>'git://github.com/igrigorik/closure-sprockets.git'" to "gem 'closure-sprockets'" and running 'bundle install', I no longer get the circular dependency error, but, obviously, the downcasing bug returns. If I then change my Gemfile back to "gem 'closure-sprockets', :git=>'git://github.com/igrigorik/closure-sprockets.git'" and run 'bundle install' again, the circular dependency bug is gone and everything works fine. But from a fresh install, installing via "gem 'closure-sprockets', :git=>'git://github.com/igrigorik/closure-sprockets.git'" first, I always get the circular dependency error. According to the Bundler docs: "If the git repository does not contain a .gemspec file, bundler will create a simple one, without any dependencies, executables or C extensions. This may work for simple gems, but not work for others. If there is no .gemspec, you probably shouldn't use the gem from git." Is that what I'm running into?

bmayen commented 12 years ago

More clarification. If I install 1e4def254eff3a06fb2e53e4c331e12252e2d78b from scratch, it works. Anything above that throws the circular dependency error unless I do the trick described above.

bmayen commented 12 years ago

Ok, in Master, if I comment out "context.require_asset 'soyutils'" in directive_processor.rb, it works

igrigorik commented 12 years ago

Ran into this earlier as well, looks like its a real bug that was previously hidden.. but latest changes in Sprockets are guarding for it.