search

igrigorik / decisiontree

ID3-based implementation of the ML Decision Tree algorithm
1.44k stars 130 forks source link

Removes continuous.png file after specs #16

Closed agarie closed 10 years ago

agarie commented 10 years ago

The "continuous.png" file is being created during some specs and ends up in the repository. This shouldn't happen.

igrigorik commented 10 years ago

Hmm, can we remove the graph calls instead?

agarie commented 10 years ago

Seems like a good idea to me. Do you think a spec for tree.graph(...) is necessary?

igrigorik commented 10 years ago

Yep, that'd make sense. Should probably check that it doesn't throw any exceptions + outputs the file, followed by an unlike to remove the artifact.

agarie commented 10 years ago

Hey @igrigorik, I made some updates to this PR. Is this what you had in mind? :P

igrigorik commented 10 years ago

Yep, looks great - thanks a lot!