search

igrigorik / em-http-request

Asynchronous HTTP Client (EventMachine + Ruby)
1.22k stars 222 forks source link

sni-hostname no longer settable #313

Open steve-misky opened 7 years ago

steve-misky commented 7 years ago

broken with v1.1.4

HttpConnectionOptions Class http_connection_options:23

Change in 1.1.4 forces the sni_hostname, EVEN if already provided

@tls[:sni_hostname] = uri.host

Simple FIX (to retain the sni_hostname IF already provided

@tls[:sni_hostname] ||= uri.host