igrigorik / em-http-request

Asynchronous HTTP Client (EventMachine + Ruby)

1.22k stars 222 forks source link

License information for stallion.rb #329

Closed hrieke closed 6 years ago

hrieke commented 6 years ago

Stallion.rb states in the header:

--

Includes portion originally Copyright (C)2008 Michael Fellinger

license See file LICENSE for details

--

I am unable to find the license information mention, nor where the source originates from. Kinda important to have this cleared up. Thanks!

igrigorik commented 6 years ago

Oi, good catch, thanks for flagging this.

@manveru having a hard time finding the relevant repo. Do you, by any chance, have a pointer?

manveru commented 6 years ago

It's probably from https://github.com/manveru/ehttp/blob/master/spec/stallion.rb - which I never put under a license. I haven't really looked at this for 10 years, but the code is from me originally and I have no issues putting it under MIT license if you'd like that.

I never used ehttp for anything but experimentation, so it's kinda cool to see that it actually had some use for someone :)

igrigorik commented 6 years ago

Thanks for the quick response Michael. If I have your approval, I propose we update header to:

# #--
# Includes portion originally Copyright (C)2008 Michael Fellinger
# MIT License
# #--

Does that look reasonable?

manveru commented 6 years ago

Sure, that looks fine

hrieke commented 6 years ago

Thanks! I would propose the following:

# #--
# Includes portion originally Copyright (C)2008 Michael Fellinger's ehttp
# https://github.com/manveru/ehttp/
# MIT License
# https://github.com/igrigorik/em-http-request/issues/329
# #--