search

igrigorik / em-http-request

Asynchronous HTTP Client (EventMachine + Ruby)
1.22k stars 222 forks source link

IPv6 literal support #330

Closed sdemjanenko closed 4 years ago

sdemjanenko commented 5 years ago

This addresses #304 . I used @foca's patch and wrote a basic test.

sdemjanenko commented 5 years ago

I am having trouble getting Travis to pass the build as it doesn't want to let me bind StubServer to the port. When I run this locally it works. Does anyone know if there a setting in the instance which is preventing binding to an address when specified on IPv6 localhost ::1?

sdemjanenko commented 5 years ago

After digging a little, it seems like this is a common issue with Travis: https://github.com/travis-ci/travis-ci/issues/10350. Others have gotten it working with sudo mode in the Travis config. I don't think that is appropriate here. Should I just mark this test as pending?

foca commented 5 years ago

Yeah, that's as far as I got back when I needed this.