search

igrigorik / em-http-request

Asynchronous HTTP Client (EventMachine + Ruby)
1.22k stars 220 forks source link

Fix failing specs and replace TravisCI with GitHub Actions #357

Closed mattbrictson closed 8 months ago

mattbrictson commented 10 months ago

Three specs were failing on the master branch. This PR fixes all three specs.

Furthermore, this repo currently had no CI coverage because Travis builds were no longer running. To fix this, this PR removes the Travis config and switches to a GitHub Actions workflow for CI.

The Travis config only tested Ruby 2.2; the new GitHub Actions workflow tests Ruby 2.2 through 3.2.

MatheusRich commented 8 months ago

@igrigorik Can you take a look at this PR? I think this gem has a Ruby 3.3 incompatibility, so I'd love to see it added to the CI testing pipeline.

mattbrictson commented 8 months ago

@igrigorik apologies, it looks like there was a typo in my workflow file that is causing the action to fail. I'll open a follow-up PR to fix it.