search

igrigorik / em-http-request

Asynchronous HTTP Client (EventMachine + Ruby)
1.22k stars 220 forks source link

Use cookiejar2 instead of cookiejar to support Ruby 3.3 #358

Closed MatheusRich closed 4 months ago

MatheusRich commented 8 months ago

Fixes #354

Regexp::new with 3 arguments is deprecated and fails on Ruby 3.3. The cookiejar gem repo has been archived, so let's use a new one.

MatheusRich commented 8 months ago

cc @igrigorik, @dorianmariefr

dorianmariecom commented 8 months ago

Would hosting it under thoughtbot organisation help?

dorianmariecom commented 8 months ago

I can also give push access to Raph e.g. anyone at thoughtbot

igrigorik commented 8 months ago

Thanks for pushing on this!

The best outcome here would be to revive and find new stewards for the existing cookiejar repo and gem. em-http is one of a number of projects depending on it, and it would be a win for everyone if we could keep current pointers instead of fragmenting the landscape. I reached out to @dwaite earlier this week but have not heard back. Let's give him a bit more time to circle back. If he's awol, then—yes—an official cookiejar replacement repo with multiple owners would be the best path forward.

dwaite commented 8 months ago

My issue has been about concerns with supply chain attacks, as I am no longer active enough in the ruby community to judge the legitimacy of an a potential adopter of the library, and ruby gems (like most language dependency managers) is rather week in features protecting against or otherwise providing transparency to such changes.

The cookiejar gem got used more than I expected it to!

But it sounds like others are fine with @dorianmariefr adopting the library. I sent a request to add you to gem ownership to your GitHub-associated email address. Please take good care of the gem!

igrigorik commented 8 months ago

@dwaite @dorianmariefr 👏🏻 ty both! 🙇🏻

dorianmariecom commented 7 months ago

@dwaite sorry I saw your invite too late, could you resend please ?

slavingia commented 6 months ago

Would be great to get an update on this.

dorianmariecom commented 6 months ago

@slavingia I got access to the cookiejar gem on rubygems

igrigorik commented 4 months ago

Are we OK to resolve / close this? @dorianmariecom all good on your end, necessary fix in place?

dwaite commented 4 months ago

AFAIK, I released a fix before turning the reins over.

dorianmariecom commented 4 months ago

@igrigorik nothing to fix right now, @dwaite did the fix a while ago, thanks to him.

So I think this can be closed