Fix GitHub Actions failures and add Ruby 3.3 to CI

mattbrictson commented 8 months ago

My initial GitHub Actions CI workflow that I provided in #357 had mistakes that are currently causing it to fail on the master branch.

The following problems are now fixed:

Fixed a - uses typo
Install libcurl4-openssl-dev dependency so that the curb gem builds
Set fail-fast: false so that one failing Ruby version in the CI matrix doesn't stop the others from running

I also added Ruby 3.3 to the build matrix. ~~Note that this version currently fails, due to known issues documented in #358.~~ Now fixed.

MatheusRich commented 8 months ago

Once this gets merged, I can rerun #358 to confirm the fix.

knu commented 8 months ago

I think you need to migrate from the archived cookiejar gem to the new cookiejar2 gem.

lawrence-forooghian commented 4 months ago

I tried running the actions from this branch on my fork and all of the jobs are passing. Has cookiejar been fixed upstream?

MatheusRich commented 4 months ago

@lawrence-forooghian yes!

mattbrictson commented 4 months ago

I just triggered CI again and all jobs are now passing in this PR, even Ruby 3.3, thanks to the cookiejar fix upstream.

igrigorik commented 4 months ago

ty sir!

igrigorik / em-http-request