search

igrigorik / em-synchrony

Fiber aware EventMachine clients and convenience classes
http://www.igvita.com/2010/03/22/untangling-evented-code-with-ruby-fibers
MIT License
1.04k stars 151 forks source link

Can't require 'em-synchrony/amqp' #178

Open hghdo opened 10 years ago

hghdo commented 10 years ago

Hi all I can't require 'em-synchrony/amqp' It complains: 

em-synchrony/amqp.rb:189:in `<module:AMQP>': undefined method `client=' for AMQP:Module (NoMethodError)

I have amqp v1.2.1 installed.

igrigorik commented 10 years ago

It's possible that amqp library has been updated and API has changed. Have you tried freezing AMQP gem with an earlier version number?

myobie commented 10 years ago

I am seeing this as well with 1.1.0, 1.2.0, and 1.3.0 of the amqp gem.

michaelkruglos commented 10 years ago

I cant say definitely, that the versions above 1.0.4 don't work. Are there any plans to support newer versions of amqp gem?

steventen commented 10 years ago

From amqp's change log: AMQ::Client has been removed since v1.1.0

dgutov commented 9 years ago

@igrigorik 

  gem 'amqp', '= 1.0.0'

does the trick.

igrigorik commented 9 years ago

@dgutov that pull conflates amqp and ActiveRecord changes. Can you make a separate commit+pull for AMQP freeze?

dgutov commented 9 years ago

@igrigorik Sure, if you think that's preferable. I can't run the specs without the other change, though.

jacobhummer commented 8 years ago

@igrigorik any chance you have insight into whether updates are coming to support AMQP gem > 1.0.4? Greatly appreciated if so.

igrigorik commented 8 years ago

@jacobhummer I've not kept up with the AMQP stuff, not sure.

jacobhummer commented 8 years ago

Thank you @igrigorik ! Definitely understandable. Hopefully I'll be able to have a go at it.

boutil commented 8 years ago

I think that just removing the line ::AMQP.client = ::EM::Synchrony::AMQP::session might be enoug to make it work with newer amqp gems. I've just run the tests on Debian unstable wich contains amqp 1.6, and they passed fine.