search

igrigorik / heroku-buildpack-dart

Heroku buildpack for Dart
170 stars 114 forks source link

Be able to override the "pub build" command #26

Closed GeReinhart closed 10 years ago

GeReinhart commented 10 years ago

See Issue #25

GeReinhart commented 10 years ago

If you want to see it live : https://drone.io/github.com/GeReinhart/dart-app-deploy-to-cloud/19

sethladd commented 10 years ago

Thanks! Looks good. Can you merge with master and repush? I'll them merge your change.

GeReinhart commented 10 years ago

Don't really get what I'm supposed to do here. It's my first pull request ever and I though you would be able to merge the pull request at this point. Maybe not.

sethladd commented 10 years ago

You're close! I think you need to do this on your fork:

(assuming you have a remote called upsteam, which is this repo)

git checkout master git fetch upstream git merge upstream/master git checkout your_branch_with_these_changes git merge master git push origin your_branch_with_these_changes

Then I think this PR will be able to be merged.

Sorry for the trouble, we're almost there.

GeReinhart commented 10 years ago

Sorry mixed up my merge...

GeReinhart commented 10 years ago

Should be ok now. see it running : https://drone.io/github.com/GeReinhart/dart-app-deploy-to-cloud/21

Hope you will be able to merge the pull request (before other commit on the master ;).

sethladd commented 10 years ago

Thanks!