search

igrigorik / heroku-buildpack-dart

Heroku buildpack for Dart
170 stars 114 forks source link

Added support for *.zip Dart SDKs for Cedar 14 #31

Closed alexpaluzzi closed 10 years ago

alexpaluzzi commented 10 years ago

This adds the ability to also use Dart SDK urls that are built to .zip files. I removed the .deb implementation until I (or someone else) has a better way to install the deb files with the buildpack.

The Linux zips can be found here: https://www.dartlang.org/tools/download_archive/

I tested with this new zip: https://storage.googleapis.com/dart-archive/channels/stable/release/39553/sdk/dartsdk-linux-x64-release.zip

I think it can certainly be improved but this gets Cedar 14 support going without breaking anyone still using Ubuntu 10.x still. Right now it's looking at the extension from the URL but I think we should consider downloading the file and then figuring out the extension to account for redirects.

I noticed when I upgraded from 1.3 to 1.6, the sample basic_http_server app broke for some reason. I didn't figure out why, but I made a quick basic server app (using Redstone) and confirmed it was something in the code sample. My next PR will be a new basic test app.

sethladd commented 10 years ago

Please update our README to talk about this new functionality. Thanks!

alexpaluzzi commented 10 years ago

Will do, tied up a bit until tonight/tomorrow. Sorry about that.

sethladd commented 10 years ago

Thanks!