search

igrigorik / heroku-buildpack-dart

Heroku buildpack for Dart
170 stars 114 forks source link

Test app doesn't serve correct static directory in Dart 1.3+ #32

Closed alexpaluzzi closed 10 years ago

alexpaluzzi commented 10 years ago 
var pathToBuild = join(dirname(Platform.script.toFilePath()), '..', 'build');

Works great in SDK ~1.2 but fails in later versions.

var pathToBuild = join(dirname(Platform.script.toFilePath()), '..', 'build/web');

Works great in newer versions, but fails in ~1.3.

Do we assume latest or check to see if /web/ exists first?

sethladd commented 10 years ago

@alexpaluzzi can a user lock their buildpack to a specific branch or tag in git? if so, let's branch for < Dart 1.3 and keep master working with latest Dart.

alexpaluzzi commented 10 years ago

@sethladd Yes they can. PR sent. Documentation to use a specific branch is here: https://devcenter.heroku.com/articles/buildpacks#using-a-custom-buildpack

sethladd commented 10 years ago

ah, great. So we should feel confident to push ahead on master only supporting Cedar 14.

What's the plan? Should I create a branch for Cedar 10?

alexpaluzzi commented 10 years ago

I like your idea of just supporting Cedar-14 by default (via master). If we want to also support Cedar 10 we should branch off.

sethladd commented 10 years ago

Fixed. Thanks for pointing this out!