Improve coverage for existing behaviour.

igrigorik / http-2

Pure Ruby implementation of HTTP/2 protocol

https://httpwg.github.io/specs/rfc7540.html

MIT License

894 stars 63 forks source link

Improve coverage for existing behaviour. #131

Closed ioquatix closed 6 years ago

ioquatix commented 6 years ago

Add Connection#closed? and Stream#closed?.
Refactor specs to improve granularity and coverage.
Specifically spec the behaviour of Client#send_connection_preface.

This PR is in preparation for refactoring how send_connection_preface works.

coveralls commented 6 years ago

Coverage increased (+0.06%) to 96.71% when pulling 025896173bcf9064bf133c59e6d2067dd8af01d3 on socketry:add-connection-closed into c3e573355b7b799f8c82d9c9d64f1fb8599ca7b2 on igrigorik:master.

igrigorik commented 6 years ago

👍

ioquatix commented 6 years ago

Do you think you can release 0.10.0 including this PR? Thanks.

igrigorik commented 6 years ago

Yes. Except, let's land https://github.com/ostinelli/apnotic/issues/68 as well before publishing 0.10.