search

igrigorik / istlsfastyet.com

Is TLS fast yet? Yes, yes it is.
https://istlsfastyet.com
421 stars 89 forks source link

Add TLS 1.3 to Go and Caddy #181

Closed ghost closed 5 years ago

ghost commented 5 years ago

This PR adds support for TLS 1.3 (RFC 8446) to Go and Caddy. TLS 1.3 support was recently added to Go. Caddy is written in Go and if you compile it with the latest branch of Go and apply a tiny patch to it, Caddy also supports TLS 1.3. To see an example of a site using Caddy with TLS 1.3, click here.

igrigorik commented 5 years ago

Hmm, what's blocking the patch from being merge into mainline? I'd love to see that be the default before we flip the bit.

p.s. thanks for drafting the update!

ghost commented 5 years ago

@igrigorik The developer of Caddy (@mholt) wants to wait for the next point release of Go (1.12) before merging it into mainline since compiling Caddy with TLS 1.3 support requires you to use a compiled version of Go's master branch instead of its current point release (1.11.2). To my knowledge, Go 1.12 is scheduled to be released in Feb 2019.

Edit: I accidentally a word.

igrigorik commented 5 years ago

Gotcha, thanks for the helpful context. Given that this still requires build-from-master and patches, I'd propose we wait until this work makes it into stable?

ghost commented 5 years ago

@igrigorik Sure thing. I'll update this pull request once TLS 1.3 support lands in the stable versions of Caddy and Go.

mholt commented 5 years ago

Thanks for the ping, and for this patch. It's a little early though :smile: All of this is correct. Shortly after Go 1.12 is released in February, Caddy will default to TLS 1.3, and we'll be tagging Caddy v1.0 sometime around then too.

ghost commented 5 years ago

@igrigorik @mholt TLS 1.3 support has landed in the stable versions of Go and Caddy. Can you merge this PR now?

igrigorik commented 5 years ago

Yep! One more thing before I merge...

Now that it's live in stable, do we have doc URLs we can point to, instead of GitHub issues?

mholt commented 5 years ago

By Monday we should. I will update this issue then.

midzer commented 5 years ago

Looks like OPs branch is gone: unknown repository

@mholt proposed changes look good to me

mholt commented 5 years ago

@whalehub Do you want to finish this up? (Where'd the repo go?)

ghost commented 5 years ago

@mholt @midzer @igrigorik I opened a new PR with the links suggested by mholt: #192