igrigorik / videospeed

HTML5 video speed controller (for Google Chrome)
https://chrome.google.com/webstore/detail/video-speed-controller/nffaoalbilbmmfgbnbgppjihopabppdk
MIT License
3.79k stars 533 forks source link

Quick shortcut overlay not shown on Twitch #1002

Open anga83 opened 1 year ago

anga83 commented 1 year ago

Twitch has apparently made some changes to their player and now the quick shortcuts overlay is no longer visible. The video speed can still be changed with the keyboard shortcuts, but you no longer see the current speed. Toggling with "v" does not show the overlay.

Maybe you can take a look at that, even though it's just a visual issue.

Tested with: 0.7.3 and 0.8.2 beta

Keep up the good work!

anga83 commented 1 year ago

Deleting "vsc-nosource" from the injected div caused the controller to appear.

Yeah, that works for me! Thanks for pointing out.

Also perhaps helpful to know: This issue appears (at least for me) only in Chrome. I can't reproduce it in Edge, but I can't say for sure if it's just coincidence or not.

watersprayh commented 1 year ago

I have the same problem and so far I have deleted the vsc-nosource tag as workaraound. Is there no permanent solution?

Kryptortio commented 1 year ago

Some ways to make it easier at least:

  1. Install Tampermonkey, create new script paste the following:
    
    // ==UserScript==
    // @name         Twitch - Fix Viudeo speed controller
    // @namespace    Twitch-FixViudeospeedcontroller
    // @version      0.1
    // @description  try to take over the world!
    // @author       You
    // @match        https://www.twitch.tv/*
    // @icon         https://www.google.com/s2/favicons?sz=64&domain=twitch.tv
    // @grant        none
    // ==/UserScript==

(function() { 'use strict'; let style = document.createElement('style'); style.textContent = 'div.vsc-nosource {display:block !important}'; document.head.append(style); })();


2. Create a bookmark, edit the bookmark and switch the url to:

javascript: (() => {let style = document.createElement('style');style.textContent = 'div.vsc-nosource {display:block !important}';document.head.append(style);})();

Click bookmark when you want to see the controls.

3. Paste the javacript in (2) in your address field (your browser will probably remove part of it so you have to fix it manually before pressing enter e.g. the "javascript:" might get removed).

4. Press F12 go to console, paste:

let style = document.createElement('style');style.textContent = 'div.vsc-nosource {display:block !important}';document.head.append(style);


Press enter.

5. Edit your addon and remove [the css rule that is causing issues](https://github.com/igrigorik/videospeed/blob/35e5a10fa7ecbbba3e88da61659960d204a0e2ae/inject.css#L1).
ghost commented 1 year ago

I have same problem too, the controls are not visible on the player whereas shortcuts still work.

SnakeSosa commented 1 year ago

Just started happening to me too on one of my 2 computers, controls work but nothing visual shows and

Deleting "vsc-nosource" from the injected div caused the controller to appear. worked for me

for the one it stopped working chrome is Version 109.0.5414.75 (Official Build) (64-bit) the one that's still working is Version 108.0.5359.125 (Official Build) (64-bit) and extension is 0.7.3 on both

hope that info helps

ghost commented 1 year ago

can someone work on this?

SnakeSosa commented 1 year ago

Unfortunately some change in twitch code causes the div to reload now when mouse moves across the video which puts back in the "vsc-nosource" and again removes the controller visually

duianto commented 3 months ago

This seems to be working for me:

System Info

Steps

SnakeSosa commented 3 months ago

This is perfect!! Thank you

synap5e commented 3 months ago

I didn't want to install another extension for this, so here is a solution using ublock origin

www.twitch.tv##.vsc-controller:remove-class(vsc-nosource)