igrigorik / videospeed

HTML5 video speed controller (for Google Chrome)
https://chrome.google.com/webstore/detail/video-speed-controller/nffaoalbilbmmfgbnbgppjihopabppdk
MIT License
3.8k stars 536 forks source link

D key (forward = pop-up tech box) S key backward = displays share options #709

Open tomlaheyh opened 3 years ago

tomlaheyh commented 3 years ago

I've seen this on a few different websites. Unfortunately, they are in paid sites like URL below; (it only impacts default keys, D and S, so changing the keys to Q and W works), so not truly a bug, but some people install and it wont work with defaults. So if this becomes a bigger problem, it might be best to change defaults??

https://members.drnajeeblectures.com/#!/video/5

The pop-up I get going forward (D key) is;

Clip ID:436811817 Delivery:application/vnd.vimeo.dash+json Codec:AVC Playing:1920×1080@30 5,181 Kbps Embed size:1057×594 Separate AV:true Dropped frames:21 / 4675 - 0.45% Playhead / buffer:175.692 / 198.198 / 22.506 Bandwidth:134,837 Kbps (47,867 Kbps143,732 Kbps)

pepijnmm commented 3 years ago

you mean like this video?: https://www.drnajeeblectures.com/introduction-to-neuroanatomy-neurophysiology/ That is a Vimeo video, for example, a YouTuber that I watch: https://vimeo.com/rossmanngroup d and s are both in use by Vimeo you could idd change it for everyone but a lot of people are now used to s and d and that we change them to keys that are now not in use by the big video platforms doesn't mean that won't use the keys in the future. Youtube or Netflix could add new keys and the extension would need to change again. For now, you could of course go into the settings of the extension and change the keys for yourself.

I am just not sure how quick platforms change the keys they use. We already know that every platform has it's own fullscreen/forward/pause keys which doesn't help(space bar luckily always works to pause XD)