igrigorik / videospeed

HTML5 video speed controller (for Google Chrome)
https://chrome.google.com/webstore/detail/video-speed-controller/nffaoalbilbmmfgbnbgppjihopabppdk
MIT License
3.83k stars 544 forks source link

Feature request: "Ignore keyboard layout" option #923

Open i-c-u-p opened 2 years ago

i-c-u-p commented 2 years ago

In the Vimium extension there's an option called "Ignore keyboard layout". If you have a non-qwerty software layout, enabling this ignores your remap and uses qwerty positions when actlvating binds. For example, on Colemak-DH the keys "mnei" are positioned where qwerty's "hjkl" would be, but with this option pressing mnei would activate the hjkl bindings anyway. My qwerty got rusty so I'm practicing that, and it'd be nice having something like Vimium's option here to avoid toggling between both layouts whenever I watch a video.

magnus-ISU commented 2 years ago

Do you know how that is implemented? I'm working on a videospeed fork (for firefox, but I was able to compile it for chrome without much issues too) and also use dvorak so I think this would be very useful. However, I don't actually know how javascript works and I don't really have time to research it right now.

i-c-u-p commented 2 years ago

Do you know how that is implemented? I'm working on a videospeed fork (for firefox, but I was able to compile it for chrome without much issues too) and also use dvorak so I think this would be very useful. However, I don't actually know how javascript works and I don't really have time to research it right now.

If I knew how to implement it, this would be a pull request 😅️