search

igrigorik / videospeed

HTML5 video speed controller (for Google Chrome)
https://chrome.google.com/webstore/detail/video-speed-controller/nffaoalbilbmmfgbnbgppjihopabppdk
MIT License
3.8k stars 536 forks source link

audio controller #980

Open abdullahkaraman opened 1 year ago

abdullahkaraman commented 1 year ago

can you add audio speed controller?

mnosov622 commented 1 year ago

Hi @abdullahkaraman !

I would love to work on this issue.

Could you assign it to me, please ?

thewheat commented 1 year ago

Hi @abdullahkaraman could we get a bit more context regarding the audio controller and any URL where we can test if needed?

Testing an mp3 on https://file-examples.com/index.php/sample-audio-files/sample-mp3-download/ and I am able to see the controller and it works at speeding things up

image
abdullahkaraman commented 1 year ago

@thewheat thanks for your return, I discovered this error on an english learning site with a podcast. You can check with this example url: http://ieslpod.com/Daily_English/0001_0100/2.html

thewheat commented 1 year ago

They look to be using a custom player that does not generate a video / audio HTML element which is what VSC looks for in order to control the speed https://github.com/igrigorik/videospeed/blob/fc1ed59274be96c451655bc71ac0776ea13782b7/inject.js#L702-L706 so I think this will just be incompatible for now

No audio / video elements

image

As a workaround you could, open up the Network tab in Chrome Developer Tools double click the mp3 (or right click > Open in new tab) and it should open in a new tab which can have the controller

image