Closed filbranden closed 2 years ago
filbranden
commented
2 years ago CI is failing on Ruby 2.0, I imagine pinning the version of one of the test gems in the client library should fix that, I'll take a look at that soon. In any case, I think we don't need to block this change, since the Rails app uses Ruby 2.6 on Heroku anyways (BTW, we should probably upgrade to 2.7 or 3+, I'll look into that soon.)
filbranden
commented
2 years ago CI issue is now resolved with #354.
codecov-commenter
commented
2 years ago Merging #353 (c1475ba) into master (2495040) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## master #353 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 27 27
Lines 802 802
=======================================
Hits 745 745
Misses 57 57 | Impacted Files | Coverage Δ | |
|---|---|---|
| app/helpers/application_helper.rb | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
This removes an external dependency that has been broken for a while.
The ruby_identicon gem produces a PNG image in a format that is suitable to use in a
data:URL, which also reduces the number of HTTP connections needed to properly render a page.Tweak the identicon size to match our 48x48 space reserved for images.
Tested: Actually pushed to both vimgolf-staging and production already.