search

igrigorik / vimgolf

Real Vim ninjas count every keystroke - do you?
http://www.vimgolf.com/
MIT License
678 stars 65 forks source link

Update Docker client image to one with more recent Vim and set up GitHub actions to keep it up-to-date #358

Closed filbranden closed 2 years ago

filbranden commented 2 years ago

Include a Dockerfile and launcher script in the main repository.

Set up GitHub action to build the image and push it to the GitHub Container Registry, do so weekly in order to keep it updated, with recent updates to the Debian Linux distribution, the Vim binary shipped by Debian, and any changes pushed to the vimgolf gem as well.

The new image is much smaller than the one originally built by Hettomei (40MiB vs 366MiB compressed, relevant for network transfers, and 140MiB vs 1GiB uncompressed, relevant when stored on disk).

The new image is also built for both 64-bit x86 and 64-bit ARM, which makes it also work on the Macbook M1.

I updated the instructions to point to the containers being built in my fork of the repository, where the GitHub Action has been running for a while. Once this PR is merged, the Action should start running here too and container images will be built here as well, so we can update the instructions to point to this one instead.

Fixes #352.

codecov-commenter commented 2 years ago

Codecov Report

Merging #358 (ccac8d0) into master (19fc0d3) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files          27       27           
  Lines         802      802           
=======================================
  Hits          745      745           
  Misses         57       57

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

filbranden commented 2 years ago

Retested this after the latest automated container build this Tuesday and it's working fine. I'll go ahead and merge this!