search

igrigorik / vimgolf

Real Vim ninjas count every keystroke - do you?
http://www.vimgolf.com/
MIT License
678 stars 65 forks source link

Drop dependencies on MongoDB libraries #361

Closed filbranden closed 2 years ago

filbranden commented 2 years ago

We're now on Postgres, so drop the gems that are related to MongoDB.

This uncovered a few issues, mainly code that was working around some MongoDB BSON encoding, also using the Symbol#in method for ActiveRecord where() queries and also some simplification was possible by dropping Keylog#parse in favor of using new() directly.

Tested: bundle exec rspec passes. Also pushed the code to vimgolf-staging and confirmed it works as exepcted by navigating and using the website, also playing some challenges.

codecov-commenter commented 2 years ago

Codecov Report

Merging #361 (ef0967a) into master (3141b7e) will decrease coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
- Coverage   92.89%   92.84%   -0.05%     
==========================================
  Files          27       26       -1     
  Lines         802      797       -5     
==========================================
- Hits          745      740       -5     
  Misses         57       57
Impacted Files Coverage Δ
app/controllers/entry_controller.rb 88.23% <ø> (ø)
app/models/entry.rb 100.00% <100.00%> (ø)
app/services/submissions.rb 98.11% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.