search

igrr / atproto

AT protocol library
Other
63 stars 15 forks source link

boot up module #6

Closed phil31 closed 9 years ago

phil31 commented 9 years ago

I would like to suggest an official message send by the module when it's ready to work. for now, I see

+CWSTAT:1 +CWSTAT:5 maybe a better message would be "ready - Ver 0.1 Rev b5dd82d " ( with for sure the corresponding Ver/Rev ) like that, when we receive at least "ready", we know that the module cab accept commands because +CWSTAT... is a reply to the command AT+CWSTAT. we don't expect this reply until we send the command ! thanks Phil
igrr commented 9 years ago

+CWSTAT is an unsolicited result code (URC), so it can appear at any time. If the module is in wifi mode 2, for instance, you won't get these result codes. You have a valid point, though, there's an explicit result code and an URC with the same name, it can lead to some confusion. Maybe one of them should be renamed.

Regarding the bootup message, I don't like the idea of plain text message with version info. There's a dedicated command, +GMR, that prints version info. How about introducing a new URC, something like +READY?

Last thing, somehow instead of creating an issue you have created a pull request from a different branch :) But never mind, I'll address your suggestions anyway.

phil31 commented 9 years ago

hi igrr

sorry about wrong place, this is my first contribution on Github ;o) as moderator, you can't move it ?

agree about +CWSTAT, maybe create another URC name !

agee too with "boot up message", what we need is a unique message when the module is ready : +READY may be useful.

regards Phil

igrr commented 9 years ago

Didn't find a way to move, so I have created #11 and #12 instead.