search

igvteam / igv-notebook

Module for embedding igv.js in an IPython notebook
MIT License
59 stars 13 forks source link

igv.js not displaying in 0.5.1 #23

Closed tmtabor closed 1 year ago

tmtabor commented 1 year ago

When I install igv-notebook 0.5.1, I am seeing an error message every time I attempt to init(). See the screenshot below.

Screen Shot 2023-05-11 at 11 41 42 AM

I have yet to go back and re-test older versions of igv-notebook, but I'll update this issue once I have done so.

tmtabor commented 1 year ago

Version 0.5.0 seems to work correctly.

jrobinso commented 1 year ago

This should be fixed, try importing the latest from master. I didn't catch this because it works in Colab. The javascript was legal and when work if imported directly, I suspect the Jupyter javascript eval function is wrapping the code in another context.

tmtabor commented 1 year ago

I have confirmed that 0.5.2 works. Thanks!