bugfix: standalone js-parsing

igvteam / igv-reports

Python application to generate self-contained pages embedding IGV visualizations, with no dependency on original input files.

MIT License

347 stars 51 forks source link

bugfix: standalone js-parsing #33

Closed FelixMoelder closed 5 years ago

FelixMoelder commented 5 years ago

This PR contains a bugfix where some lines in the html-template were recognized as JS-Files. This happens as line.find("<script") returns -1 if the string is not found in the current line. So, this part of the if-closure always returns true and every line holding the substring ".js" is parsed as JS-File if the standalone-parameter is set.

jrobinso commented 5 years ago

thanks

johanneskoester commented 5 years ago

@jrobinso can we get a new release please? Thanks in advance!

jrobinso commented 5 years ago

@johanneskoester Yes, thanks for the reminder. Do you have any comments on https://github.com/igvteam/igv-reports/pull/34?

jrobinso commented 5 years ago

Released - v 0.9.3.