search

igvteam / igv.js

Embeddable genomic visualization component based on the Integrative Genomics Viewer
MIT License
638 stars 225 forks source link

Sequence Track not using nucleotideColors creation option #1849

Closed eternal-flame-AD closed 4 weeks ago

eternal-flame-AD commented 1 month ago

Hi, this happened when I was validating function signature for the ts definitions, the sequence track does not use the nucleotideColors creation option. I git blamed to this commit: https://github.com/igvteam/igv.js/commit/92c1ab93a3c444f5f328476fd319fc3ffe6e095d

I was confused, why take away an option that otherwise don't change anything? The commit message just says "Changes to support juicebox.js." I traced the linked PR and the issue board I don't find anything explaining this change. so i'm not sure..

If this is intended and there is a valid reason for that, I think it should be reflected on the API docs.

jrobinso commented 1 month ago

So is the report that the nucelotideColors option described here is ignored? https://github.com/igvteam/igv.js/wiki/Browser-Creation

eternal-flame-AD commented 1 month ago

Yes