igvteam / igv.js

Embeddable genomic visualization component based on the Integrative Genomics Viewer
MIT License
643 stars 230 forks source link

Rendering of zoom buttons and menu bar and settings doesn't work #570

Closed jimhavrilla closed 6 years ago

jimhavrilla commented 6 years ago

image I have changed nothing in my html (https://s3.us-east-2.amazonaws.com/ccrs/ccr.html) and since the recent update the page looks like the above. Is there a potential cause of this? I can't give specifics because I truly do not know what change caused this.

jrobinso commented 6 years ago

Hi, some dtails please. What am I looking for (what us the problem?). Update of what? Can you give me a url to the page?

On Tue, Mar 27, 2018 at 1:50 PM Jim Havrilla notifications@github.com wrote:

[image: image] https://user-images.githubusercontent.com/6568964/37994165-f43f9250-31cd-11e8-8605-824c8c51c099.png I have changed nothing in my html ( https://s3.us-east-2.amazonaws.com/ccrs/ccr.html) and since the recent update the page looks like the above. Is there a potential cause of this? I can't give specifics because I truly do not know what change caused this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/igvteam/igv.js/issues/570, or mute the thread https://github.com/notifications/unsubscribe-auth/AA49HNcsL9JRjLCBLKpj0OOqgY8m6-WXks5tiqYjgaJpZM4S9neO .

-- Sent from Gmail Mobile

jimhavrilla commented 6 years ago

URL is above. The problem is that the zoom buttons and the menu bar on the top of the container, and the settings wheel on the right of the tracks has mysteriously vanished. Not really sure what could be the cause. As you can see in the posted image above the top menu bar just says "cursor guide center line track labels" but no longer has buttons or functionality. Also the update to which I am referring is your master branch, my guess is #569, but there have been several pretty recent multi-commit PRs so I really couldn't tell you what is the cause.

jrobinso commented 6 years ago

Be sure you update the css as well. Also, remove the font awesome includes. Could you give me a url to rhe page?

On Tue, Mar 27, 2018 at 2:08 PM Jim Havrilla notifications@github.com wrote:

Also the update to which I am referring is your master branch

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/igvteam/igv.js/issues/570#issuecomment-376676051, or mute the thread https://github.com/notifications/unsubscribe-auth/AA49HJd8C-xk38C7qMuo1X_cFcfqgAZjks5tiqpbgaJpZM4S9neO .

-- Sent from Gmail Mobile

jimhavrilla commented 6 years ago

The url is here: https://s3.us-east-2.amazonaws.com/ccrs/ccr.html. Also, I use the "web/test/dist" release for both the CSS and the JS. I removed the font awesome but it seemed to make no difference.

helgathorv commented 6 years ago

To @jimhavrilla: A message from @jrobinso: He's not at a computer right now, but will take a look this evening (California time).

jimhavrilla commented 6 years ago

I gathered as much -- got those github mobile labels in the comments. Thanks for taking a look in advance.

jrobinso commented 6 years ago

Hi jim, I'll ook at this this evening. But FYI web/test/dist is not recommended for anything other than testing, that is not built off master but off of our development branch, its primary purpose is to test prior to merging to master. The most recent build from master will be at http://igv.org/web/beta/

jimhavrilla commented 6 years ago

I will make the switch then later and let you know if it works -- Jim Havrilla PhD Candidate in Human Genetics, University of Utah Accelerated BS/MS in Biomedical Engineering, Drexel University '12, Concentration: Bioinformatics "Memory, comprehension, communication, motivation"

jrobinso commented 6 years ago

OK, I found the problem. The URL for the distribution css has changed, its

https://igv.org/web/test/dist/igv.css

instead of

https://igv.org/web/test/dist/css/igv.css

To fix it I made a copy, so you don't need to do anything now.

Since you are testing on our dev branch , the big change in that branch is the font-awesome css is no longer used. Instead we embed font-awesome v5 in the igv.js and igv.css bundles. The embedded code uses svg graphics, not fonts.

jimhavrilla commented 6 years ago

Works now. I like using your new features :) so that's why I use the dev branch. One question, for the future should I now use

https://igv.org/web/test/dist/css/igv.css

Or do you guys plan to go back to the old URL?

Jim Havrilla PhD Candidate in Human Genetics, University of Utah Accelerated BS/MS in Biomedical Engineering, Drexel University '12, Concentration: Bioinformatics "Memory, comprehension, communication, motivation"

On Tue, Mar 27, 2018 at 7:48 PM, Jim Robinson notifications@github.com wrote:

OK, I found the problem. The URL for the distribution css has changed, its

https://igv.org/web/test/dist/igv.css

instead of

https://igv.org/web/test/dist/css/igv.css

To fix it I made a copy, so you don't need to do anything now.

Since you are testing on our dev branch , the big change in that branch is the font-awesome css is no longer used. Instead we embed font-awesome v5 in the igv.js and igv.css bundles. The embedded code uses svg graphics, not fonts.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/igvteam/igv.js/issues/570#issuecomment-376732629, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQ8BDpVrS5CAutSFEt3fa4myGe9asmWks5tiuvhgaJpZM4S9neO .

jrobinso commented 6 years ago

@jimhavrilla Its actually very helpful to have you using the latest bleeding edge, as long as this isn't a production or public site that people count on. If it is we can set some semi-stable process up for you to get regular updates but not multiple times per day.

Going forward, as in starting tomorrow, these are the urls for the latest build, which is kicked off on literally every commit. Note there is no css subfolder, and the igv css file is now "igv-all.css". I decided to rename it as it is a conctenation of 2 css files in our source tree.

https://igv.org/web/test/dist/igv-all.css
https://igv.org/web/test/dist/igv.js
jimhavrilla commented 6 years ago

Thanks. It is used by other people, it is public and I am the only one who maintains it at the moment. But a lot of your new features I incorporate pretty immediately, so if you are willing to make that semi-stable release I would appreciate it.

jrobinso commented 6 years ago

We are working towards a process for more frequent releases, on the order of monthly, that are tagged so your site won't change until you are ready for it to. In the meantime the "beta" distribution I pointed you to earlier is safer than the test one. We don't push things to the beta until we have tested it. That doesn't mean we will find all bugs but your odds are better there.

When we roll out frequent tagged releases you can point production to them, and set up a mirror of your site pointing to our test distribution for testing before updating your site to a more recent tag.

jimhavrilla commented 6 years ago

Sounds good. Thanks Jim.