igwgames / nes-starter-kit

A Beginner's Guide and toolkit for NES game creation.
MIT License
221 stars 24 forks source link

For functions that don't accept parameters, add void in parenthesis. #19

Closed ericandrewlewis closed 5 years ago

ericandrewlewis commented 5 years ago

This avoids conflicting type errors in some versions of cc65 and is closer to what C's type system expects.

See #18.

potatolain commented 5 years ago

I'm surprised at how many places you had to change - it seems like maybe I updated the C files, but left the headers alone? Thanks for taking the time to help iron that out.

This change looks good to me, and it compiles/runs correctly on the distributed version of cc65 too. I need to update some of the guide to match, so I may leave this sitting for a little while until I find time to do that. (Hopefully by the end of the week)

Thanks for the PR!