ihadeed / CordovaYoutubeVideoPlayer

Play Youtube Videos in a native Video Player on Android & iOS
MIT License
23 stars 49 forks source link

IOS build Fail #7

Open dotorl opened 4 years ago

dotorl commented 4 years ago

Hi, @ihadeed

"@ionic/angular": "^4.11.7", "@ionic-native/youtube-video-player": "^5.21.4", "cordova-plugin-youtube-video-player": "2.4.0", "@angular/common": "~8.1.2", "@angular/compiler": "~8.1.2", "@angular/core": "~8.1.2", "cordova-android": "8.1.0", "cordova-ios": "5.1.1",

It works well on Android.

but, It cannot be build in IOS...

[cordova] [cordova] ** BUILD FAILED ** [cordova] [cordova] [cordova] The following build commands failed: [cordova] CompileC /Users/ctsoft/Library/Developer/Xcode/DerivedData/edume-aozxplehlcprepgdnaexsfzmsuow/Build/Intermediates.noindex/edume.build/Debug-iphonesimulator/edume.build/Objects-normal/x86_64/YoutubeVideoPlayer.o /Users/ctsoft/Desktop/dev/edume/platforms/ios/edume/Plugins/cordova-plugin-youtube-video-player/YoutubeVideoPlayer.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler [cordova] (1 failure) [cordova] xcodebuild: Command failed with exit code 65

Is there anything else I need to setting?

Here in the 'JonSmart/CordovaYoutubeVideoPlayer' plug-in, the build succeeds.

Please Help me.

sjregan commented 4 years ago

I'm getting the same error.

@KwandSeokCho Did you find a solution?

dotorl commented 4 years ago

@sjregan

I'm sorry. I haven't found a solution. And after a while, I forgot.

And I am not good at English. Maybe you don't understand.

build Success in Xcode as far as I remember. not 'ionic cordova build ios'

So, it was hard because I kept building whenever code changed.

T.T

sjregan commented 4 years ago

@KwandSeokCho thank you, your English is fine :)

I solved this by removing the iOS platform, upgraded XCode from 11.3 to 11.4. Added the iOS platform and built from within XCode.

sjregan commented 4 years ago

Turns out this is still an issue for me, it works by building within XCode but does not work from the command line.

rbrand21 commented 4 years ago

@sjregan Same for me. My whole build process is wonky because of this but as of now, don't have an alternative. I have to do an ionic build, then build again within xcode for code updates to be reflected inside the simulator.

rbrand21 commented 4 years ago

@sjregan This plugin points to a release of the iOS plugin (XCDYouTubeKit) that's like 5 minor versions behind. I wonder if this has something to do with it?

dotorl commented 4 years ago

@sjregan @rbrand21

i don't use it command line... .T.T

Build only through Xcode....

I'm done developing.

So it's not that uncomfortable, but it's hard every time I fix it.

dtpmilke commented 3 years ago

Correct import in YoutubeVideoPlayer.h is #import <XCDYouTubeKit/XCDYouTubeVideoPlayerViewController.h>

and in YoutubeVideoPlayer.m #import <XCDYouTubeKit/XCDYouTubeKit.h>

sachithd commented 3 years ago

Correct import in YoutubeVideoPlayer.h is #import <XCDYouTubeKit/XCDYouTubeVideoPlayerViewController.h>

and in YoutubeVideoPlayer.m #import <XCDYouTubeKit/XCDYouTubeKit.h>

This actually worked. Thank you. After making the changes remove the iOS platform and add again.