ihalila / pancurses

A Rust curses library, supports Unix platforms and Windows
MIT License
396 stars 44 forks source link

make `pancurses` work with `ncurses` 6.0.1 #93

Open correabuscar opened 5 months ago

correabuscar commented 5 months ago

but first, ncurses-rs needs the changes in this PR : https://github.com/jeaye/ncurses-rs/pull/220 (but the below were tested only with PR https://github.com/jeaye/ncurses-rs/pull/218 which is a superset PR which handles more error cases/warnings and overall improves build, I'll have to retest depending on which PR, if ever, gets merged) this got in https://github.com/jeaye/ncurses-rs/pull/220 as v6.0.1 (already on crates.io), so I'm testing with this version.

Note: KEY_EVENT went away, though it wasn't used anywhere in pancurses.

Closes #92

Legend:

The above are checked to be true on:

TODO:

ihalila commented 5 months ago

Thanks for the PR. I'll look through this as soon as I find a bit of time.

correabuscar commented 5 months ago

No worries, it's still in draft phase until the ncurses-rs one gets in(if ever), then I'll mark it ready for review, no need to look at it before then, I think.

correabuscar commented 2 months ago

Closing this to allow someone else in the future to come along and do things better whenever things are ready in ncurses-rs, and also because I've already closed the prerequisite PR for ncurses-rs (for same reason) and without it this PR has no point:) Also, I may or may not be here in the future to provide support for these changes, as I had originally intended. Although these changes are quite minor so it wouldn't have mattered.

correabuscar commented 2 months ago

Reopening because https://github.com/jeaye/ncurses-rs/pull/220 got in, so this PR might work now, bare with me while I re-test everything in OP...

correabuscar commented 2 months ago

I forgot that I had deleted the virtual machines, so testing was now only done on Gentoo... but otherwise the PR is ready. Note that the ncurses crate had already published version 6.0.1 which is required for this PR to work (already enforced).

EDIT: technically only this 1 of the 3 commits is needed. Can cherry-pick it, or tell me whether or not to remove the other 2 and force-push ?