search

ihavenoface / 4chan-x

Adds cute bloat.
https://4chan-x.org
Other
22 stars 14 forks source link

Constant Errors on inline quoted Embedding #310

Closed ILsAllDoomed closed 10 years ago

ILsAllDoomed commented 10 years ago

At random periods it will just crash. Sometimes it will work, other times it will shit out errors like nobody's business-

"Embedding" crashed on Clone No.######(/z/).
TypeError: el is null
"Embedding" crashed on Clone No.######(/z/).
TypeError: el is null
"Embedding" crashed on Clone No.######(/z/).
TypeError: el is null
"Embedding" crashed on Clone No.######(/z/).
TypeError: el is null
"Embedding" crashed on Clone No.######(/z/).
TypeError: el is null
"Embedding" crashed on Clone No.######(/z/).
TypeError: el is null

Also I've found that when it does work, it has two [Embed] tags- the first one doesn't work at all, but the second does.

Great feature but it's broken 60% of the time with inline quoting

ihavenoface commented 10 years ago

Do you have an example thread?

two [Embed] tags

Can't reproduce. Please make sure you don't have any other addon / script active that might be interfering with 4chan X.

ILsAllDoomed commented 10 years ago

You were right. Whenever I have 4chan Media Player active it breaks it but only in some threads, like this one- http://boards.4chan.org/a/res/105495049#p105500523 capture I'm using the latest version of it (5.0.5), should I repost this there?

Also, though you can see the [Embed] in the picture clicking on it doesn't work just to clear that up.

ihavenoface commented 10 years ago

You shouldn't run both anyway so I doubt they will care about this issue. You can disable Embedding in 4chan X if you would like to use 4chan Media Player.

ILsAllDoomed commented 10 years ago

You shouldn't run both anyway.

Why? They do completely different things. They shouldn't even be interacting with a strawpoll since 4chan Media Player has nothing to do with that.

ihavenoface commented 10 years ago

They do completely different things.

Both are suitable for embedding content.

ILsAllDoomed commented 10 years ago

Well it's supposed to only work with sound related links not strawpoll. I apologize for bothering you with something that's not the fault of your script.