iheanyi / bandcamp-dl

Simple python script to download Bandcamp albums
The Unlicense
941 stars 104 forks source link

bandcamp-dl cannot be installed with setuptools >= 58.0.2 due to "demjson" dependency #189

Closed valpogus closed 2 years ago

valpogus commented 2 years ago

Describe the bug bandcamp-dl cannot be installed because the dependency "demjson" uses "use_2to3" during build, which is removed in setuptools >= 58.0.2.

To Reproduce

rm -rf ~/.cache/pip/
python3 -m pip install setuptools==58.0.2
python3 -m pip install bandcamp-downloader demjson==2.2.4

error in demjson setup command: use_2to3 is invalid.

Expected behavior The package bandcamp-downloader is correctly installed.

Desktop

Additional context Other projects depending on demjson are migrating to the new library "demjson3". The library "demjson3" works only on Python 3 and using it would mean removing support for Python 2, but according to the changelog, support for Python 2 was "officially" removed on version 0.0.6.

Evolution0 commented 2 years ago

Yep should just be a matter of switching the dependency and testing to make sure everything works but from the sound of it its a drop-in replacement.

Evolution0 commented 2 years ago

Fixed in 0.0.11, pending release.