search

iheanyi / bandcamp-dl

Simple python script to download Bandcamp albums
The Unlicense
941 stars 104 forks source link

Add --no-confirm option #205

Closed JOJ0 closed 1 year ago

JOJ0 commented 1 year ago

This new option allows to skip the confirmation prompt when albums are incomplete and possibly can be used for future things that might include prompting the user for something.

I went with --no-confirm as the long-option name since --yes could be confused with the already existing -y short-option. Most probably this option will be used in scripts, thus I think a medium long option name like that is ok.

Evolution0 commented 1 year ago

I prefer readability so it all looks fine to me.

Evolution0 commented 1 year ago

Give me a bit to push a pypi build, after a Windows update last night my system would no longer boot, startup repair, DISM repair, restore, etc nothing would fix it so I had to go through my usual process of backing everything important up from one of my live linux drives and doing a fresh install.

I may finish the small bit of code needed for #201 just to give me a reason to version bump before doing so.

JOJ0 commented 1 year ago

Hi, please drop me a note when you find time to kick out a new release. There is no rush on this, I'll watch your repo for releases I guess. Maybe this is just a reminder to myself :-) Thanks anyway!

I've opened a draft PR in the actual project that was the reason for submitting this new feature: https://github.com/doctorfree/MusicPlayerPlus/pull/31

I'll set this ready to merge once the feature is released.

Evolution0 commented 1 year ago

Once I've got my logger util functions sorted I can push my last changes and make a release. I had noticed during my testing after adding config files that debugging had likely been broken for some time as using the option output absolutely nothing.

So I'm now making a proper set of loggers with formatting, log files, and rotating logs.

JOJ0 commented 8 months ago

Any chance you could release this tiny feature without ypur logger improvements?

Evolution0 commented 7 months ago

Any chance you could release this tiny feature without ypur logger improvements?

Currently backing up my dev branch and hopping back into master to see if I can get an actual Pypi release pushed, I haven't done so since Pypi removed the legacy backend as I previously had issues authenticating. Ideally I get a build released sometime today that has everything currently in master.

Edit: Current master released as 0.0.15 on Pypi