search

iheartradio / ficus

Scala-friendly companion to Typesafe config
MIT License
327 stars 55 forks source link

Support reading int range #156

Closed SHaaD94 closed 3 years ago

SHaaD94 commented 3 years ago

Hi, thanks for the great library! I've decided it would be cool to be able to read ranges from the config.

kailuowang commented 3 years ago

I agree that it's cool, but since this format of "from x to y step z " is a bit arbitrary I am not sure if such custom instances of ValueReader belong to the library. I'd argue that it is better to just leave them in individual projects.

SHaaD94 commented 3 years ago

Thanks for the prompt reply.

I agree, this format is pretty straightforward, but reading Range is still kinda important for some apps.

Perhaps you have a bit more generic format in mind?

kailuowang commented 3 years ago

I don't. That's why I think it's hard to provide a default instance and it's best for each use implement their own instance, that's the main benefit of the typeclass design, isn't it?

On Fri, Jul 16, 2021, 9:51 PM Evgeniy Zuikin @.***> wrote:

Thanks for the prompt reply.

I agree, this format is pretty straightforward, but reading Range is still kinda important for some apps.

Perhaps you have a bit more generic format in mind?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/iheartradio/ficus/pull/156#issuecomment-881796711, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUKOIK5CY7NSGPGX46K3TTYDOZBANCNFSM5APVMGWA .