search

iheartradio / ficus

Scala-friendly companion to Typesafe config
MIT License
327 stars 55 forks source link

(WIP) Scala 3 cross compile #158

Open hughsimpson opened 3 years ago

hughsimpson commented 3 years ago

The innocuous bits:

Lots of things still to figure out:

Would probably be sensible to take the scalafmt change and the syntactic restrictions as a single pr, and figure out how to make the macros work incrementally. I think I might forget about this, 'cause it's not even a direct dependency of mine, but thought it was only fair to show my working nonetheless. If there's any interest in this work I'm happy to split this pr up into mergeable and work-in-progress

kailuowang commented 3 years ago

Have you considered switching to some other libs?

On Fri, Aug 13, 2021, 6:03 PM hughsimpson @.***> wrote:

Lots of things still to figure out:

  • Can't get defaults working. Man, I don't know what's up with that
  • Assumes contructor methods are the only valid ones. This should be (compared to the above) fairly easy to fix
  • I think there's some capability to declare bespoke config parsing? I haven't gone near that yet

You can view, comment on, or merge this pull request online at:

https://github.com/iheartradio/ficus/pull/158 Commit Summary

  • some initial cross-compilation stuff
  • wippery
  • lol wip

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/iheartradio/ficus/pull/158, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUKOLRZE5QQJYN52BFTXDT4WJEJANCNFSM5CELKK5A .

hughsimpson commented 3 years ago

To be completely honest I don't even use this. It's a dependency of a test dependency of a dependency that I can do without, this is just for fun really. I was pretty hesitant even to open the WIP for that reason but I'd put a few hours in and thought I'd gauge if there was any interest, in which case I might pursue this, if only as an excuse to fiddle with scala 3 macros a bit more. I won't be salty if this pr is closed with a 'won't fix' or whatever - not least because I'm aware how glaringly incomplete it is as a PR and because as it stands it would change the API

kailuowang commented 3 years ago

I think a more worthwhile endeavor might be PR to help your test dependency to migrate away from ficus. I have a gut feeling that it will take less effort. Ficus depends on scala-reflect which is not supported by scala 3

On Sun, Aug 15, 2021, 3:55 PM hughsimpson @.***> wrote:

To be completely honest I don't even use this. It's a dependency of a test dependency of a dependency, this is just for fun really

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/iheartradio/ficus/pull/158#issuecomment-899101897, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUKOKAPWTGV5YZZJ4JFEDT5ALURANCNFSM5CELKK5A .