search

iheos / iheos-toolkit3

1 stars 0 forks source link

toolkit.properties has moved #36

Closed iheos closed 8 years ago

iheos commented 11 years ago

Originally reported by: Bill Majurski (Bitbucket: bmajur, GitHub: Unknown)

As part of the transition to the code and resource layout required by maven, I've moved toolkit.properties from WEB-INF to WEB-INF/classes. This allows it to be loaded via the class loader. I've committed these changes in my code. In doing this I have broken your unit tests since they establish toolkit.properties under WEB-INF and my support code does not align. I would appreciate it if you could do the necessary repair work to the repository project on the default branch.

iheos commented 11 years ago

Original comment by Sunil Bhaskarla (Bitbucket: skbhaskarla, GitHub: skbhaskarla):

Fixed.

https://bitbucket.org/iheos/toolkit/commits/5f8d505a2bb5375c6e9da68f23d3c869e39ee9af

iheos commented 11 years ago

Original comment by Sunil Bhaskarla (Bitbucket: skbhaskarla, GitHub: skbhaskarla):

#!java

!txt

```I am looking at this error

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running gov.nist.hit.ds.repository.simple.SimpleTestSuite
/C:/Users/skb1/Documents/toolkit-defaultbr/repository/target/test-classes/Installation/
Running testPurgeIndex...
Running testIndexContainer...
New index container created.
Running testRemoveContainer...
patientId
location
parentId
startTime
description
type
lf: 30
lf: 30
ttt
log4j:WARN No appenders could be found for logger (gov.nist.hit.ds.initialization.installation.PropertyServiceManager).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
java.lang.NullPointerException
    at java.util.Properties$LineReader.readLine(Properties.java:418)
iheos commented 11 years ago

Original comment by Sunil Bhaskarla (Bitbucket: skbhaskarla, GitHub: skbhaskarla):

The repository unit tests (or the test suite) were broken because the Initialization getToolkitProperties method was updated. Relocating the the repository's toolkit.properties resource will fix the problem.