search

iheos / iheos-toolkit3

1 stars 0 forks source link

SOAP API #50

Open iheos opened 11 years ago

iheos commented 11 years ago

Originally reported by: Bill Majurski (Bitbucket: bmajur, GitHub: Unknown)

Create an API for soap client.

iheos commented 10 years ago

Original comment by antoine gerardin (Bitbucket: agerardin, GitHub: agerardin):

RequestParams or RequestConfig actually documents the intent of this object. I tend to wrap generic types for this purpose, especially at the API level. Also it provides a convenient place to document the properties that can be passed.

iheos commented 10 years ago

Original comment by Bill Majurski (Bitbucket: bmajur, GitHub: Unknown):

In interface named SoapClient, please document the call(s) and the properties use. This property documentation should include, for each property, name, default value, acceptable values, purpose and use of property. Required|optional status.

iheos commented 10 years ago

Original comment by Bill Majurski (Bitbucket: bmajur, GitHub: Unknown):

Since your current properties object is a simple extension of the Java Properties class, why not just use the Properties class. I'm not sure extending it achieves anything.

iheos commented 10 years ago

Original comment by Bill Majurski (Bitbucket: bmajur, GitHub: Unknown):

Please create a public API (Java Interface) so that both an Axis2 and a home-built implementation can hide behind the same interface. SoapClient seems like a good name for this interface.

iheos commented 10 years ago

Original comment by antoine gerardin (Bitbucket: agerardin, GitHub: agerardin):

Need to pass payload and custom headers