iherman / rdfjs-c14n-tester

Testing the rdfjs-c14n
Other
2 stars 0 forks source link

Integration with `rdf-test-suite` #3

Open jeswr opened 2 months ago

jeswr commented 2 months ago

Just stumbled across this in passing, nice work!

I wanted to note that @rubensworks already has https://github.com/rubensworks/rdf-test-suite.js/ for RDF and SPARQL tests. It might be valuable to use the logic here to implement a C14n support to that library to support re-usability across other C14n implementations.

iherman commented 2 months ago

I will look into it, but it may take some time...

iherman commented 2 months ago

I've just had a quick look at the test suite repository and, to be honest, it looks fairly difficult to understand how all this works and, mainly, what has to be done to add a new c14n support entry using the Working Group's test suite. Is there a comprehensible documentation about this somewhere? Reverse engineering existing code is really not ideal...

The other possibly is that someone, who is knowledgeable on the test suite, leads the work and I can assist him/her with whatever is necessary.

rubensworks commented 2 months ago

Hi @iherman 👋

If c14n test manifest support were to be added to rdf-test-suite.js, a new ITestCaseHandler would have to be added to TestCaseHandlers based on c14n's test types.

An ITestCaseHandler essentially converts a test case resource (all triples related to a test collected in a Resource object) into an ITestCase. An ITestCase can then be executed later by the runner if needed.

The TestCaseEvalHandler might be the easiest one to use as an example, which is the one used for parsers.

This context file is also important, as it contains the shortcuts that will be used when converting parsed test manifests into a Resource. So some entries may have to be added there.