ihexxa / quickshare

Quick and simple file sharing between different devices, built with Go, React and Typescript.
https://ihexxa.github.io/quickshare.site
GNU Lesser General Public License v3.0
506 stars 32 forks source link

captchaEnabled config partially working #123

Closed WLun001 closed 2 years ago

WLun001 commented 2 years ago

captchaEnabled should be inside users level https://github.com/ihexxa/quickshare/blob/65da92aece7ac78a493b19d07d8a02c7ccbdb54d/src/server/config.go#L27

but the config is provided at server level https://github.com/ihexxa/quickshare/blob/65da92aece7ac78a493b19d07d8a02c7ccbdb54d/configs/docker.yml#L17

even if set to captchaEnabled: false at user level, at login UI still can see it but able to click Login without providing captcha

image

ihexxa commented 2 years ago

I'll submit a fix for this, thanks for the feedback!