search

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.72k stars 377 forks source link

Graphic flaws of small sprites of creatures #1335

Open LeHerosInconnu opened 4 years ago

LeHerosInconnu commented 4 years ago

@Branikolog

In Heroes 2, there are a lot of small graphical flaws. Some of its flaws are present in fheroes2. I haven't compared to see if they are all present in fheroes2.

For example, for small sprites of creatures in fheroes2: Rangers have no shadow, champion feathers are cut at the top of the sprite, master swordsmen feathers are cut to the left and top of the sprite, veteran pikemen feathers are cut at the top of the sprite, the titan's shoulder pad can be improved.

Graphic flaws of small sprites of creatures 01

All these little flaws, and more, have already been fixed. Here is a quote from Forums of Enroth:

Here is a thread https://heroes2.forumactif.com/t303-changes-to-the-game-s-graphics where changes have been made to the game graphics to correct some problems encountered. Certainly some files won't be needed as they fix display priority issues in different castles and I haven't started testing fheroes2 yet. All the changes made are indicated in the changelog. Some of these files have been modified by Uhm, try contacting him on this site to see if it is possible to use some of his modifications for your project. For the modifications made by me, it's okay. :)

Other Forums of Enroth links on this topic: https://heroes2.forumactif.com/t903-recruitment-tavern https://heroes2.forumactif.com/t930-fheroes2-0-8-graphics-issues-with-fheroes2

ihhub commented 3 years ago

Hi @LeHerosInconnu , I'm going to fix all these issues with small sprites of creatures. Using modified resources is not a legally correct way but we can modify them in the game itself. I'll make some changes for obvious sprites but I'll need your help to modify the rest. What I need to to describe what exactly we need to change in the original sprite: add a shadow (copy from another sprite), add pixel A at position (X, Y) or something else.

ihhub commented 3 years ago

Hi @LeHerosInconnu please take a look at #2292 . I attached images there.

LeHerosInconnu commented 3 years ago

Hello @ihhub,

Hi @LeHerosInconnu , I'm going to fix all these issues with small sprites of creatures. Using modified resources is not a legally correct way but we can modify them in the game itself. I'll make some changes for obvious sprites but I'll need your help to modify the rest. What I need to to describe what exactly we need to change in the original sprite: add a shadow (copy from another sprite), add pixel A at position (X, Y) or something else.

Give me some time and I'll take care of it. :)

ihhub commented 3 years ago

Sure!

LeHerosInconnu commented 3 years ago

@ihhub.

Here are the images before and after the changes. (After @ihhub applied the "automatic" creature shadow correction (https://github.com/ihhub/fheroes2/pull/3284), I noticed that some of my manual shadow pixel corrections were not correct, the comparison sprites have not been replaced). I only put the difference file (images with black background) for those images where only few changes were made. All files are available in the zip file with better quality as github degrades the quality of the uploaded images. Changes to files from MONS32.ICN.zip

You can use DiffImg to compare images visually and MtPaint for pixel coordinates and palette colors. https://sourceforge.net/projects/diffimg/ http://mtpaint.sourceforge.net/

All the changes on the graphics are related to the file: MONS32.ICN

0000.bmp - Peasant

0002.bmp - Ranger (corrected)

0004.bmp - Veteran Pickman (corrected)

0005.bmp - Swordman

0006.bmp - Master Swordman (your changes are not correct)

0007.bmp - Cavalry

0008.bmp - Champion (your changes are not correct, black pixels along the edge of the spear)

0009.bmp - Paladin

0010.bmp - Crusader

0015.bmp - Ogre (corrected)

0016.bmp - Ogre Lord (corrected)

0020.bmp - Sprite (corrected)

0029.bmp - Centaur (corrected)

0038.bmp - Halfling (corrected)

0044.bmp - Archmage (corrected)

0045.bmp - Giant

0046.bmp - Titan

0047.bmp - Skeleton

0048.bmp - Zombie

0049.bmp - Zombie Mutant

0050.bmp - Mummy

0051.bmp - Royal Mummy

0054.bmp - Lich (corrected)

0057.bmp - Rogue

0058.bmp - Nomad

0059.bmp - Ghost (corrected)

0063.bmp - Air Elemental (corrected)

ihhub commented 3 years ago

Hi @LeHerosInconnu , could you please update this topic based on latest (in an hour built) version?

LeHerosInconnu commented 3 years ago

Hello @ihhub,

Hi @LeHerosInconnu , could you please update this topic based on latest (in an hour built) version?

I'll look at this tomorrow, it's time to go to sleep. :)

LeHerosInconnu commented 3 years ago

Hello @ihhub,

Hello @ihhub,

Hi @LeHerosInconnu , could you please update this topic based on latest (in an hour built) version?

I'll look at this tomorrow, it's time to go to sleep. :)

I have updated the post with the graphics.

ihhub commented 3 years ago

Air elemental also corrected :)

LeHerosInconnu commented 3 years ago

@ihhub.

Air elemental also corrected :)

Oops, I compared the wrong elemental. :) That's corrected.

a1exsh commented 3 years ago

Is there anything left to do for this issue?

LeHerosInconnu commented 3 years ago

@a1exsh.

Is there anything left to do for this issue?

@ihhub was working on it. I haven't seen any changes or messages from him since the last correction in this thread. In the post with the creature graphics, it says "(corrected)" after the creature name when all the necessary corrections have been made. And "(corrected)" is indicated for each line of change for those corrected. All modification lines that do not end with "(corrected)" are therefore to be corrected. :)