search

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.67k stars 373 forks source link

Combat screen, logs list, the border of the buttons and the scroll bar does not have a yellow border on the left #1371

Open LeHerosInconnu opened 4 years ago

LeHerosInconnu commented 4 years ago

The border of the buttons and the scroll bar does not have a yellow border on the left (1 pixel wide).

Combat screen, logs list, yellow border 01

a1exsh commented 2 years ago

While working on a fix in #4251, I've realized that the scrollbar should be situated next to the list, not inside it, and hence no extra yellow line is needed.

How about this (just a mockup, not coded yet): image

LeHerosInconnu commented 2 years ago

Hello @a1exsh,

Yes, it's better this way. :) It's like in the scenario editor. I think all the windows that use this scrollbar should be this way.

zenseii commented 1 year ago

image Do you still think this needs a border on the left side, @LeHerosInconnu?

LeHerosInconnu commented 1 year ago

Hello @zenseii,

image Do you still think this needs a border on the left side, @LeHerosInconnu?

Apparently, this has not been fully implemented as proposed:

While working on a fix in #4251, I've realized that the scrollbar should be situated next to the list, not inside it, and hence no extra yellow line is needed.

How about this (just a mockup, not coded yet): image

The scroll bar should be positioned as in the scenario editor screen to avoid having to add a border.

Scenario editor:

Scroll bar logs 002