ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.7k stars 375 forks source link

Combat screen, logs list, expression used for the position of hexagons #1372

Open LeHerosInconnu opened 4 years ago

LeHerosInconnu commented 4 years ago

In the logs list, the expressions used for the position of the hexagons are not very indicative. "Moved Champions: 9, 4", "Moved Champions: 31, 24".

Expression position of hexagons 01

I suggest improving this a bit to make it more understandable.

The horizontal lines of hexagons, starting from the top of the screen, are referenced with the letters of the alphabet. The first horizontal line of hexagons is referenced with the letter "A". The second horizontal line of hexagons with the letter "B". The third horizontal line of hexagons with the letter "C". Etc.

The hexagons in each horizontal line, starting from the left of the screen, are referenced with numbers. The first hexagon of each line is referenced with the number "1". The second hexagon of each line is referenced with the number "2". The third hexagon of each line is referenced with the number "3". Etc.

The first hexagon, starting from the left of the screen, of the first line, starting from the top of the screen, is therefore referenced "A1".

A troop moving from this hexagon into the fifth hexagon in the same line would be indicated by the expression "A1, A5". "Moved Goblins: A1, A5" instead of "Moved Goblins: 0, 4".

A troop moving from the first hexagon into the fifth hexagon of the last line of hexagons would be indicated by the expression "I1, I5". "Moved Goblins: I1, I5" instead of "Moved Goblins: 88, 92".

For creatures occupying two hexagons, both hexagons are indicated. "Moved Champions: A10-11, A7-8" instead of "Moved Champions: 9, 6".

And also, I suggest putting the name of the creature first in each sentence. So to write: "Goblins move: A1, A5" "Goblins move: I1, I5" "Champions move:" A10-11, A7-8"

And write "Champions skip turn" instead of "Champions skipping turn".

Branikolog commented 4 years ago

Not all players want to watch this numbers and letters in battle log. I suggest simply type something like that: "Goblins take a new position"

LeHerosInconnu commented 4 years ago

@Branikolog.

Not all players want to watch this numbers and letters in battle log. I suggest simply type something like that: "Goblins take a new position"

If the position information is to be removed, it would be preferable to leave the notion of movement anyway: "Goblins move to a new position."

Branikolog commented 4 years ago

@LeHerosInconnu

"Goblins move to a new position."

For me it sounds perfect! Thanks for your suggestions!

Anyway, we can leave the position information as option, which is switched off on default.

LeHerosInconnu commented 4 years ago

@Branikolog.

@LeHerosInconnu

"Goblins move to a new position."

For me it sounds perfect! Thanks for your suggestions!

Anyway, we can leave the position information as option, which is switched off on default.

Yes, this information can be useful. It would be nice to have an option to display them. :)

ihhub commented 1 year ago

Hi @LeHerosInconnu , is this issue still relevant? We show row and column numbers for the logging.

Mr-Bajs commented 1 year ago

If the cordinates in battle should be kept in the log, then i would agree using a classic chesslike system with A1 - C4 style is better than the current system with only numericals.

LeHerosInconnu commented 1 year ago

Hello @ihhub,

Hi @LeHerosInconnu , is this issue still relevant? We show row and column numbers for the logging.

The use of the two numbers to locate the hexagon remains confusing to me. The use of a letter and a number would greatly help in representing the position of the hexagon. Because a letter is different from a number, confusion is reduced.