ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.71k stars 376 forks source link

Hero screen, primary skill info windows, text layout and concordance text #1431

Open LeHerosInconnu opened 4 years ago

LeHerosInconnu commented 4 years ago

In fheroes2, the information window indicates the "Current Modifiers" for the primary skills. I really like this improvement over the original game. :) However, there are some things that can be improved.

The two-line display of the artifact name and the artifact bonus is not always ideal. For example, for the text "Defender Helm of Protection +1" the text "+1" is written alone on the second line. It's not very pretty. When this happens, the written text should be adapted to avoid this. For example, for the text "Armored Gauntlets of Protection +1", the text "Protection +1" is on the second line, which is already much nicer.

There is also a mismatch between the text displayed for the artifact bonus and the number of similar artifacts. In the example, the hero has several artifacts in duplicate, but the bonus is only indicated once. This is confusing, and it would be nice to match the written text with the number of artifacts when there are multiple copies of the same artifact. For example, for the text "Defender Helm of Protection +1", the written text should be "Defender Helms of Protection +2" or possibly "Defender Helms of Protection +2 (2)", the "(2)" specifying the number of copies of the same artifact owned.

In fheroes2:

Primary skill info window 01

Primary skill info window 02

LeHerosInconnu commented 4 years ago

A larger version of the info window (or a version that adapts automatically) can also be used in order to have the text for each artifact on a single line.

Branikolog commented 4 years ago

I like an idea of moving previous from "+1" word, to the next line.

LeHerosInconnu commented 4 years ago

Hi @Branikolog,

The advantage of having a larger window with the text of each artifact on a single line would be to be able to display the text for fourteen artifacts. :)

LeHerosInconnu commented 4 years ago

Info window with fourteen lines for the "Current Modifiers". :)

Primary skill info window 03