search

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.69k stars 375 forks source link

Castle construction screen, shadow of the text in the information bar at the bottom of the screen, the shadow of the text should not be displayed over the yellow frame of the info bar #1745

Open LeHerosInconnu opened 4 years ago

LeHerosInconnu commented 4 years ago

In fheroes2, the shadow of the text is displayed over the yellow frame of the info bar. In the original game, this is not the case.

In original game:

Building sign position H2 01

In fheroes2:

Building sign position fh2 01

Similar issues: https://github.com/ihhub/fheroes2/issues/1675, https://github.com/ihhub/fheroes2/issues/1728.

Branikolog commented 4 years ago

Isn't it the same issue you talked about here #1728?

LeHerosInconnu commented 4 years ago

@Branikolog.

Isn't it the same issue you talked about here #1728?

Yes, it's the same problem but in a different window. I would group the same type of issues in the same thread in the future.

Branikolog commented 4 years ago

Should I close this for now?

LeHerosInconnu commented 4 years ago

@Branikolog.

Should I close this for now?

Why? Are these two windows managed by the same part of the code?

Branikolog commented 4 years ago

Yes. information bar for all of this windows is the same, as well, as text font. So, the issues regarding font shadows, are part of the same code.

LeHerosInconnu commented 4 years ago

@Branikolog.

Yes. information bar for all of this windows is the same, as well, as text font. So, the issues regarding font shadows, are part of the same code.

Do what you think is best to get the job done right. :)

Branikolog commented 4 years ago

It's ok! :) You can always ask me in discord for the cases, you're not sure about. Or here, at a similar topic, if you find one.

LeHerosInconnu commented 4 years ago

@Branikolog.

It's ok! :) You can always ask me in discord for the cases, you're not sure about. Or here, at a similar topic, if you find one.

Okay, thank you.

zenseii commented 2 years ago

The text just needs to be shifted up one pixel: image

LeHerosInconnu commented 2 years ago

Hello @zenseii,

The text just needs to be shifted up one pixel: image

I think that it will unbalance the visual in the case of a text with no letters with a jamb (letters of the Latin alphabet with a jamb: " g ", " j ", " p ", " q " et " y "). Better not to display the shadow of the letters with jamb over the yellow frame, which is the case in the original game for some screens.

In original game:

No shadow over yellow frame letter with jamb 01

Edit.

Or the vertical position of the text can be adjusted depending on whether the text contains letters with a jamb or not.